mojohaus / jaxws-maven-plugin

https://www.mojohaus.org/jaxws-maven-plugin/
Apache License 2.0
25 stars 37 forks source link

Issue #60: Need to use the nonProxyHosts from the maven settings #62

Closed beirtipol closed 6 years ago

beirtipol commented 6 years ago

Split out the logic for getting a handle to the proxy and investigate for the wsdlURL being present in the nonProxyHosts before adding the command line arg

michael-o commented 6 years ago

I have decided to close this PR for several unrelated changes:

  1. Auth information for proxy is an unrelated change
  2. Matching the WSDL URL against the current proxy is shortsighted. How do you know what includes are in the schema files? You don't.

Feel free to provide another PR for the first issue.

beirtipol commented 6 years ago
  1. The auth information for the proxy is optional and the standard way to pass authentication information along with a proxy string.
  2. I don't understand what you're trying to say.
michael-o commented 6 years ago
  1. Though, your statement is correct, the change is still unrelated to nonProxyHosts.
  2. You cannot use regex matching at code time because the proxy is required for XSD includes and others discovered at runtime.
beirtipol commented 6 years ago
  1. So you're ok with the change, but want it in a separate PR?
  2. Have you got an example of this I can use to test?
michael-o commented 6 years ago
  1. Yes, that is correct.
  2. Here is a sample with xmime namespace:

    <xs:element name="UploadNamedReference">
            <xs:complexType>
                    <xs:simpleContent>
                            <xs:extension base="xs:base64Binary"
                                    xmime:expectedContentTypes="*/*">
                                    <xs:attribute name="datasetUid" type="common:uid" use="required" />
                                    <xs:attribute name="filename" type="common:filename" use="required" />
                            </xs:extension>
                    </xs:simpleContent>
            </xs:complexType>
    </xs:element>

The xmine will cause an external schema to fetch: the autogenerated schema at runtime will contain:

<xs:import namespace="http://www.w3.org/2005/05/xmlmime" schemaLocation="http://www.w3.org/2005/05/xmlmime"/>