mojohaus / jaxws-maven-plugin

https://www.mojohaus.org/jaxws-maven-plugin/
Apache License 2.0
25 stars 37 forks source link

Fixes IT jaxwscommons-81 and updates jaxws-tools dependency to v2.3.2 #78

Closed andham closed 4 years ago

andham commented 4 years ago

This is a follow up to PR #71.

andham commented 4 years ago

@theit Are you on windows by any chance and can verify this?

theit commented 4 years ago

@andham: On my Mac everything works, both with Java 8 and Java 13. On a 64-bit Windows 10 VM this looks slightly different: All IT tests pass apart from issue-15 and jaxwscommons-4 which fail, independent of the JVM I'm using: Java 8 and 11 from adoptopenjdk.net with Hotspot and/or OpenJ9. I assume that it's simply my environment...

andham commented 4 years ago

Thanks for verifying @theit ! Issues with other ITs on windows is a separate topic. Unfortunately, most of us are on mac or linux and travis only executes linux builds.

theit commented 4 years ago

The problem of the failing tests obviously is that the home directory of my user has a space in it. Issue-15 IT's build.log contains the following errors:

(...)
[INFO]
[INFO] --- jaxws-maven-plugin:2.6-SNAPSHOT:wsimport (id2) @ mojo.it.issue-15 ---
[DEBUG] Configuring mojo org.codehaus.mojo:jaxws-maven-plugin:2.6-SNAPSHOT:wsimport from
plugin realm ClassRealm[plugin>org.codehaus.mojo:jaxws-maven-plugin:2.6-SNAPSHOT, parent:
 sun.misc.Launcher$AppClassLoader@7852e922]
(...)
[DEBUG] The wsdl Directory is C:\Users\Thorsten Heit\git\andham-jaxws-maven-plugin\target\it tests\issue-15\src\wsdl
[ERROR]
java.io.FileNotFoundException: C:\Users\Thorsten%20Heit\git\andham-jaxws-maven-plugin\target\it-repo\org\jvnet\jax-ws-commons\tests\wsdl-lib1\1.0-SNAPSHOT\wsdl-lib1-1.0-SNAPSHOT.jar (Das System kann den angegebenen Pfad nicht finden)
    at java.util.zip.ZipFile.open (Native Method)
    at java.util.zip.ZipFile.<init> (ZipFile.java:225)
    at java.util.zip.ZipFile.<init> (ZipFile.java:155)
    at java.util.jar.JarFile.<init> (JarFile.java:166)
    at java.util.jar.JarFile.<init> (JarFile.java:103)
    at org.codehaus.mojo.jaxws.WsImportMojo.getWSDLFiles (WsImportMojo.java:657)
    at org.codehaus.mojo.jaxws.WsImportMojo.executeJaxws (WsImportMojo.java:284)
(...)

And later:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12.364 s
[INFO] Finished at: 2019-12-31T17:54:20+01:00
[INFO] ------------------------------------------------------------------------
Running post-build script: C:\Users\Thorsten Heit\git\andham-jaxws-maven-plugin\target\it tests\issue-15\verify.groovy
Assertion failed:

assert source.exists()
       |      |
       |      false
       C:\Users\Thorsten Heit\git\andham-jaxws-maven-plugin\target\it tests\issue-15\target\generated-sources\wsimport\ws2\ProcessOrder.java

        at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:404)

The same error messages appear in the build.log for jaxwscommons-4.

When I create a junction for that "missing" directory via command line with administrative rights: %> junction -d "Thorsten%20Heit" "Thorsten Heit"

and rerun "mvn -Prun-its clean verify", the above errors in the ITs disappear, and another one comes up:

(...)
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO]   Passed: 3, Failed: 0, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M4:integration-test (integration-test-verify) @ jaxws-maven-plugin ---
[INFO]
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running TestSuite
[ERROR] Tests run: 13, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 1.094 s <<< FAILURE! - in TestSuite
[ERROR] org.codehaus.mojo.jaxws.MixedITCase.jaxwscommons81_wsgen  Time elapsed: 0.016 s  <<< FAILURE!
java.lang.AssertionError: Not found C:\Users\Thorsten Heit\git\andham-jaxws-maven-plugin\target\it tests\jaxwscommons-81\target\custom\sources\org\jvnet\jax_ws_commons\jaxws\test\jaxws\EchoResponse.java expected [true] but found [false]
        at org.codehaus.mojo.jaxws.MixedITCase.jaxwscommons81_wsgen(MixedITCase.java:100)

[ERROR] org.codehaus.mojo.jaxws.MixedITCase.jaxwscommons81_wsimport  Time elapsed: 0 s  <<< FAILURE!
java.lang.AssertionError: Not found C:\Users\Thorsten Heit\git\andham-jaxws-maven-plugin\target\it tests\jaxwscommons-81\target\classes\org\jvnet\jax_ws_commons\wsimport\test\HelloWs.class expected [true] but found [false]
        at org.codehaus.mojo.jaxws.MixedITCase.jaxwscommons81_wsimport(MixedITCase.java:55)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   MixedITCase.jaxwscommons81_wsgen:100 Not found C:\Users\Thorsten Heit\git\andham-jaxws-maven-plugin\target\it tests\jaxwscommons-81\target\custom\sources\org\jvnet\jax_ws_commons\jaxws\test\jaxws\EchoResponse.java expected [true] but found [false]
[ERROR]   MixedITCase.jaxwscommons81_wsimport:55 Not found C:\Users\Thorsten Heit\git\andham-jaxws-maven-plugin\target\it tests\jaxwscommons-81\target\classes\org\jvnet\jax_ws_commons\wsimport\test\HelloWs.class expected [true] but found [false]
[INFO]
[ERROR] Tests run: 13, Failures: 2, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M4:verify (integration-test-verify) @ jaxws-maven-plugin ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
(...)