search

mojohaus / mojo-parent

This is the parent pom for all MojoHaus Maven plugins and components.
https://www.mojohaus.org/mojo-parent/
123 stars 59 forks source link

Wrong minimal required Maven version for plugins #383

Closed slachiewicz closed 1 year ago

slachiewicz commented 1 year ago 
mvn -V help:help

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T20:33:14+02:00)
Maven home: /Users/slachiewicz/Downloads/apache-maven-3.5.4
Java version: 20, vendor: Azul Systems, Inc., runtime: /Library/Java/JavaVirtualMachines/zulu-20.jdk/Contents/Home
Default locale: en_PL, platform encoding: UTF-8
OS name: "mac os x", version: "13.2.1", arch: "aarch64", family: "mac"
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.codehaus.mojo:mojo-parent >--------------------
[INFO] Building MojoHaus Parent 75-SNAPSHOT
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.215 s
[INFO] Finished at: 2023-03-30T01:08:16+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-help-plugin:3.4.0:help (default-cli) on project mojo-parent: The plugin org.apache.maven.plugins:maven-help-plugin:3.4.0 requires Maven version 3.6.3 -> [Help 1]

same reported by versions plugin

~/Downloads/apache-maven-3.5.4/bin/mvn versions:display-plugin-updates
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.codehaus.mojo:mojo-parent >--------------------
[INFO] Building MojoHaus Parent 75-SNAPSHOT
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- versions-maven-plugin:2.15.0:display-plugin-updates (default-cli) @ mojo-parent ---
[INFO]
[INFO] The following plugin updates are available:
[INFO]   maven-scm-publish-plugin ........................... 3.1.0 -> 3.2.1
[INFO]   maven-site-plugin .............................. 3.12.1 -> 4.0.0-M6
[INFO]   org.codehaus.mojo:flatten-maven-plugin ............. 1.3.0 -> 1.4.1
[INFO]   org.codehaus.mojo:license-maven-plugin ................ 1.9 -> 1.20
[INFO]
[INFO] All plugins have a version specified.
[INFO]
[INFO] Project requires minimum Maven version for build of: 3.2.5
[INFO] Plugins require minimum Maven version of: 3.6.3
[INFO]
[ERROR] Project requires an incorrect minimum version of Maven.
[ERROR] Update the pom.xml to contain maven-enforcer-plugin to
[ERROR] force the Maven version which is needed to build this project.
[ERROR] See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
[ERROR] Using the minimum version of Maven: 3.2.5
[INFO]
[INFO] Require Maven 3.5.4 to use the following plugin updates:
[INFO]   org.codehaus.mojo:license-maven-plugin ............... 1.9 -> 2.0.0
[INFO]
[INFO] Require Maven 3.6.3 to use the following plugin updates:
[INFO]   maven-help-plugin ........................................... 3.4.0
slawekjaranowski commented 1 year ago

So what proposition is?

Should we switch minimal Maven version for build? It will have impact to minimal version for testing.

slachiewicz commented 1 year ago

This affects only this one plugin, everything else should work normally. To rise version globally i think we should have vote on mailing list

slawekjaranowski commented 1 year ago

Similar discussion will be on ASF Maven ... https://issues.apache.org/jira/browse/MPOM-398

When we bump minimal version for build it will only block Maven version used for testing. But agree we should vote / discuss on mailing list.

slawekjaranowski commented 1 year ago

Similar discussion started on Maven list: https://lists.apache.org/thread/plg8r9nxwybd7wsdwz1lf7v0241gg34f

slawekjaranowski commented 1 year ago

More plugins requires newer version of Maven:

[INFO] Require Maven 3.5.4 to use the following plugin updates:
[INFO]   org.codehaus.modello:modello-maven-plugin ................... 2.1.2
[INFO]   org.codehaus.mojo:flatten-maven-plugin ...................... 1.5.0
[INFO]   org.codehaus.mojo:license-maven-plugin ...................... 2.1.0
[INFO] 
[INFO] Require Maven 3.6.3 to use the following plugin updates:
[INFO]   maven-help-plugin ........................................... 3.4.0

Even more 3.6.x is also EOL - https://maven.apache.org/docs/history.html

slawekjaranowski commented 1 year ago

and mojohaus dev list - https://groups.google.com/g/mojohaus-dev/c/Zcl2_Elotd4

slawekjaranowski commented 1 year ago

According to discussion on dev list - we can upgrade to the 3.6.3