search

mojohaus / rpm-maven-plugin

http://www.mojohaus.org/rpm-maven-plugin/
Other
56 stars 48 forks source link

Scriptlet examples and dead links in documentation #128

Closed senderic closed 3 years ago

senderic commented 3 years ago

Are there example scripts for http://www.mojohaus.org/rpm-maven-plugin/adv-params.html#Scripts?

I know I could google examples, however what I find are documents for generating scriptlets that include %post, %prerun, %postrun, etc all in the same file. With this maven plugin, it seems each of the sections need to be made seperatly. So, I am hoping to see examples of best practices of how to write out these scriptlets for this maven plugin.

For example, in the documentation it shows this:

<preinstallScriptlet>
  <scriptFile>/src/main/bin/preinstall.sh</scriptFile>
  <fileEncoding>utf-8</fileEncoding>
  <filter>true</filter>
</preinstallScriptlet>

But there is no link/example of the innards of preinstall.sh.

Also, in the documentation there are references to documentation which are dead links, such as:

So I suppose this issue is two fold:

  1. Please provide examples of using scriptlets specific to this plugin
  2. Please update the links provided in the documentation.
senderic commented 3 years ago

Update: Now that I found this repo, I noticed there are examples here: https://github.com/mojohaus/rpm-maven-plugin/tree/master/src/it

So all I can say is it would be nice to link examples in the documentation. Also, on the top right of the documentation web page, the git repo links to https://github.com/mojohaus/mojo-parent, not this repo.