mojohaus / rpm-maven-plugin

http://www.mojohaus.org/rpm-maven-plugin/
Other
56 stars 48 forks source link

System or user modifications to rpm path macros break the plugin #13

Closed tmzullinger closed 9 years ago

tmzullinger commented 9 years ago

If a /etc/rpm/macros or ~/.rpmmacros adjust path macros like _builddir, _rpmdir, _sourcedir, _specdir, _srcrpmdir, or _build_name_fmt, the plugin fails as it expects the generated packages to be in the default locations.

The plugin sets _topdir. It should similarly set the other path macros so that it can be sure where the packages will be created. (Alternately, rpm --eval could be used to check the paths, but that's a much bigger change with dubious benefits.)

I've created a patch to set the necessary --define options. I'm not familiar with the testing methods here, so if anyone could lend a hand on what I may need to do in that regard, I would appreciate it.

dantran commented 9 years ago

merge at https://github.com/mojohaus/rpm-maven-plugin/commit/0f280c186794bac1366d3f4598f223f375651431 Thanks