2.1.4 -> 2.1.5 changes spec file from a included directory to list of files.

[snigel]

When updating from 2.1.4 to 2.1.5 the generated spec file becomes different for one of my projects.

Instead of including the source directory (as in 2.1.4), it creates a list of the files inside the directory. This causes issues, since that means that the RPM no longer owns the root directory, only the files inside.

I have tried to create a simple test case for reproducing this, but strangely my minimal pom is working fine.

For my broken project, I managed to get the directory included again by enabling: <recurseDirectories>true</recurseDirectories> But if I do that, I get both the directory and a list of all files in my spec file. The build log will also complain about warning: File listed twice

I see that some code regarding creation of spec files has been changed in 2.1.5 but I can't figure out what is happening in my case.

[dantran]

2.1.5 introduce an optimization large large single directory mapping (#40 ) keep a minimal spec file with a simple directory inclusion. here is an example how to activate it

<mapping>
          <directory>some-rpm-directory</directory>
          <sources>
            <source>
              <location>some-local-directory</location>
              <noDefaultExcludes>true</noDefaultExcludes>
            </source>
          </sources>
 </mapping>

other than that, it should be fully backward compatible.

[snigel]

Hello dantran, I tried running with <noDefaultExcludes>true</noDefaultExcludes>, the spec file still looks similar, a list of files, but no inclusion of the directory.

Also, is there a list for what exclusions DefaultExcludes contain? I couldn't find anything about it.

[dantran]

did you remove recurseDirectories ??

[snigel]

Yes. So the duplicate warning disappeared but it's still a list of files instead of a directory.

[dantran]

@snigel possible to share your pom.xml? to my email at dantranATgmail.com? before and after changes