search

mojohaus / rpm-maven-plugin

http://www.mojohaus.org/rpm-maven-plugin/
Other
56 stars 48 forks source link

Supports using all-numeric modifiers as release. #56

Open asgeirn opened 8 years ago

asgeirn commented 8 years ago

Fix for issue #55

dantran commented 8 years ago

is it a backward compatible change?

asgeirn commented 8 years ago

It will only alter the behavior for situations where POM versions are configured with build numbers according to the Maven version number rules: http://www.mojohaus.org/versions-maven-plugin/version-rules.html

Previously, this plugin would append _1 to the RPM release number, while it now uses the build number exactly as the release number.

For situations where POM versions use qualifiers, which by definition are not all-numeric, the plugin will retain the previous behavior.

I'd argue that this is the least confusing behavior in scenarios where the POM version is in fact compatible with RPM versioning rules.

dantran commented 8 years ago

See my comment on your open issue #55. It works very well for my productions build we heavily depend on this feature. So if you need this new behavior, you must provide an option to activate it, plus doc, and test.

It is very critical that we keep new change backward compatible