search

mojohaus / rpm-maven-plugin

http://www.mojohaus.org/rpm-maven-plugin/
Other
56 stars 48 forks source link

Allow for scriptlets and triggers to be filtered with properties. #57

Closed chiknrice closed 8 years ago

chiknrice commented 8 years ago

A new configuration property "filter" were added for scriptlets and triggers. The underlying implementation uses the default filter wrappers available in the RPM mojo.

Both script or scriptFile can be filtered with standard maven filtering by setting the "filter" parameter to true:

                    <preinstallScriptlet>
                        <scriptFile>rpm/preInstall.sh</scriptFile>
                        <filter>true</filter>
                    </preinstallScriptlet>
dantran commented 8 years ago

Please add test and doc. Thanks for helping out

chiknrice commented 8 years ago

Added test and doc.

chiknrice commented 8 years ago

@dantran are my test & doc acceptable?

chiknrice commented 8 years ago

@dantran any news on my PR? thanks!

rickard-von-essen commented 8 years ago

LGTM 👍

xandris commented 7 years ago

this is super useful for us right now. when will 2.2.0 drop? 😄