search

mojohaus / rpm-maven-plugin

http://www.mojohaus.org/rpm-maven-plugin/
Other
56 stars 48 forks source link

add support for rpmbuild stages #66

Closed wdpypere closed 7 years ago

wdpypere commented 7 years ago

This allows people to use the plugin to make source rpms.

rickard-von-essen commented 7 years ago

Can you explain in which scenario this would be useful? Since this wouldn't really allow building SRPM that you can build in the traditional sense.

jrha commented 7 years ago

@rickard-von-essen, it is not intended that the SRPMs would be used to rebuild (from source), but they would make repackaging much easier. We have some users who like to produce internal variants of our upstream packages. We would like to make this process easier for them without having to use our complete build environment.

rickard-von-essen commented 7 years ago

I'm a bit reluctant to add this feature since it slightly redefines the meaning of srpm.

rickard-von-essen commented 7 years ago

@dantran What's your view on this?

dantran commented 7 years ago

@rickard-von-essen i see no issue

rickard-von-essen commented 7 years ago

Ok, then we can merge this if you add some docs, unit tests and at least on It.

wdpypere commented 7 years ago

@rickard-von-essen I added some documentation and tests.

rickard-von-essen commented 7 years ago

LGTM

wdpypere commented 7 years ago

@rickard-von-essen I see there are preparations for a 2.2.0 release, would this be included? Thanks.