Please release a new version that includes the threadSafe fix

XN137 commented 2 years ago

this was fixed in https://github.com/mojohaus/tidy-maven-plugin/issues/27 however no new version was released since then.

we would like to avoid these warnings in all of our modules:

2022-03-10T07:47:46.4483999Z [INFO] --------------------------------[ jar ]---------------------------------
2022-03-10T07:47:46.4484394Z [WARNING] *****************************************************************
2022-03-10T07:47:46.4484675Z [WARNING] * Your build is requesting parallel execution, but project      *
2022-03-10T07:47:46.4484980Z [WARNING] * contains the following plugin(s) that have goals not marked   *
2022-03-10T07:47:46.4485294Z [WARNING] * as @threadSafe to support parallel building.                  *
2022-03-10T07:47:46.4485660Z [WARNING] * While this /may/ work fine, please look for plugin updates    *
2022-03-10T07:47:46.4486065Z [WARNING] * and/or request plugins be made thread-safe.                   *
2022-03-10T07:47:46.4486369Z [WARNING] * If reporting an issue, report it against the plugin in        *
2022-03-10T07:47:46.4486730Z [WARNING] * question, not against maven-core                              *
2022-03-10T07:47:46.4486979Z [WARNING] *****************************************************************
2022-03-10T07:47:46.4487376Z [WARNING] The following plugins are not marked @threadSafe in (project):
2022-03-10T07:47:46.4487791Z [WARNING] org.codehaus.mojo:tidy-maven-plugin:1.1.0
2022-03-10T07:47:46.4488107Z [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
2022-03-10T07:47:46.4488392Z [WARNING] *****************************************************************

Thank you

mohanaraosv commented 2 years ago

Bump!! It's been so long since the last version is released. Please consider for new release.

bmarwell commented 2 years ago

Can do, but does it still work properly?

Stephan202 commented 2 years ago

@bmarwell we're using this plugin in hundreds/thousands of concurrent builds each day (running mvn tidy:pom) and I don't recall any concurrency issue that was traced back to this plugin. :+1:

mohanaraosv commented 2 years ago

Even I use this plugin in concurrent multi-module builds and never faced any issue.

bmarwell commented 2 years ago

Great! Just asking because of the recent java11+ builds. Thanks for your input!

Stephan202 commented 2 years ago

Can confirm compatibility with both JDK 11 and 17 :+1:

pzygielo commented 2 years ago

Please.

slawekjaranowski commented 2 years ago

Before release please help with:

upgrade parent to the latest version
cleanup of configuration in pom which is provided by parent
upgrade Maven api to 3.2.5 - Maven core component in provided scope
check/fix site output

pzygielo commented 2 years ago

Before release please help with:

check/fix site output

Noticed changes with site generated from 40650bb4c5dfabb9b3f2617577e17e18b667f150 compared with d1510677c7981c9789405d2c7755570b25f7304d:

cobertura report gone (https://github.com/mojohaus/mojo-parent/pull/79)
github report gone (https://github.com/mojohaus/mojo-parent/commit/3798c4e3567a2af89df1427d8bed4874d0fdaddd, https://github.com/mojohaus/mojo-parent/issues/113)
renames due to https://issues.apache.org/jira/browse/MPIR-323 and https://github.com/mojohaus/mojo-parent/pull/137
differences related to switch from javadoc7 to javadoc8 (required by https://github.com/mojohaus/mojo-parent/commit/790440982fcbf1b5c29513cc9ff21c25a8899a76)

slawekjaranowski commented 2 years ago

@pzygielo thanks ...

I will try release until end of month

slawekjaranowski commented 2 years ago

Done.

mojohaus / tidy-maven-plugin

Please release a new version that includes the threadSafe fix #54