search

mojohaus / xml-maven-plugin

XML Maven Plugin
https://www.mojohaus.org/xml-maven-plugin/
Apache License 2.0
23 stars 21 forks source link

option to skip plugin execution #2

Closed romani closed 9 years ago

romani commented 9 years ago

Almost all plugins have a option to skip execution without changes to pom.xml that is very useful to and let users have one configuration and run build by sub-phases (not as monolith phase). Additionally it helps to skip plugin from running till bug fix is not released.

Examples of how our project do control of verify phase - https://github.com/checkstyle/checkstyle/blob/master/.travis.yml#L22.

Additional problem we found is that plugin rely on internet access to get xsd and dtd files, that make build unstable and we would rather move validation of xml files to separate build phase. I will try to show place there en example (do not have now as I always relaunch build to make it green).

Example of failure from users: https://github.com/checkstyle/checkstyle/issues/2191#issuecomment-142892825

jochenw commented 9 years ago

I have added a parameter "skip" with default "${xml.skip}". (Not yet committed, because I am waiting for the required permissions.)

The problem that I do see here: This parameter applies to both "xml:validate" (aka ValidateMojo), and "xml:transform" (aka TransformMojo), which might be a bit confusing, and/or misleading.

jochenw commented 9 years ago

Just committed, closing.

romani commented 8 years ago

is it possible to make a release of this plugin ? please share plan for next release.

vramik commented 8 years ago

+1 for releasing new version with this fix

khmarbaise commented 8 years ago

Started release VOTE...

https://groups.google.com/forum/#!forum/mojohaus-dev