Fixes for Issues #16 (mojo parameter checks), with test cases

mojohaus / xml-maven-plugin

XML Maven Plugin

https://www.mojohaus.org/xml-maven-plugin/

Apache License 2.0

23 stars 21 forks source link

Fixes for Issues #16 (mojo parameter checks), with test cases #22

Closed rosslamont closed 7 years ago

rosslamont commented 7 years ago

Fixes:

issue #16 (mojo parameter checks)

Throws exceptions when bogus parameters are passed to the mojo.

....

Apologies for the multiple commits - the last commit reverts my files back to the original change. I'll re-add those changes in later PRs once this one is through.

Also, apologies for the 9 files, 7 are test case files, and they are pretty much copies of existing test cases.

khmarbaise commented 7 years ago

Hi, first thanks for your contributions but it's really needed to have only a single issue done within a single PR...which means you should make a single PR for a single issue...I'm appreciate to further help....furthermore could you please squash your commits into a single one to have the relationship into the history more clear and not distributed over several commits..

rosslamont commented 7 years ago

Hi Karl,

Apologies for the run-around. I'm a bit embarrassed, I've been developing for 25 years, but I am new to git / github / open source. So I made a bit of a mess of my local trying to move my revisions aside, as I have quite a few. Long story short, I have my revisions parked in a side branch and I will feed them to you now slowly. But I had to drop my master and reset it back to the fork origin point, so this PR had to close. New PR is #23.

Cheers Ross

khmarbaise commented 7 years ago

no need to apologize. No problem. I'm doing dev for about 30 years+ etc. but I learned one important thing: I know that I know nothing which means I can always learn new things...and most important is: ask questions to learn... so not a problem....It's very good that are trying to contribute to open source projects...and I appreciate your efforts...If you have further problem don't hesitate to ask via email or on the mailing list https://groups.google.com/forum/#!forum/mojohaus-dev etc.