search

mojohaus / xml-maven-plugin

XML Maven Plugin
https://www.mojohaus.org/xml-maven-plugin/
Apache License 2.0
23 stars 21 forks source link

Fixed #34. Handle relative href in xml-model processing instructions #35

Closed rosslamont closed 6 years ago

rosslamont commented 6 years ago

Motivation: When resolving xml-model style validations, relative href do not work. As this is relying on the EntityResolver, there are possibly other relative entity resolutions which do not work either.

Solution: Added relative URI handling to the resolveURL method of Resolver class. Code attempts the original code path before attempting to resolve relative URI's to preserver legacy behavior as much as possible.

Fixed #34

rosslamont commented 6 years ago

closing: wrong solution - this solution interferes with the "basedir" mojo parameter. Probably a better solution for v2.0

rosslamont commented 6 years ago

Upon further thought, it was possible to keep the original resolution approach which first tries to resolve as a URI, and then attempts to use basedir. If the original approach fails, and the URI is relative, then the new approach is used.