search

mojohaus / xml-maven-plugin

XML Maven Plugin
https://www.mojohaus.org/xml-maven-plugin/
Apache License 2.0
23 stars 21 forks source link

Add .travis.yml to have integration builds for every pull request #6

Closed ppalaga closed 9 years ago

ppalaga commented 9 years ago

I hope that the idea of having TravisCI builds for every PR and merge is generally acceptable.

I have seen that org.codehaus.mojo:mojo-parent defines the Java source and target levels at 1.4. However, the oldest Java available in Travis is OpenJDK6, see http://docs.travis-ci.com/user/languages/java/#Testing-Against-Multiple-JDKs

So I have added OpenJDK6 plus OpenJDK7 and OracleJDK8 to the build matirix: https://github.com/mojohaus/xml-maven-plugin/commit/9fad25dec2cd3947bc3b5a2fd9fd5c26dc5594f3#diff-354f30a63fb0907d4ad57269548329e3R5

To see how and if at all the proposed .travis.xml file works, one of the project owners should add the TravisCI service in https://github.com/mojohaus/xml-maven-plugin/settings/hooks

ppalaga commented 9 years ago

Oh, looking again, mojo.java.target is 1.7inorg.codehaus.mojo:mojo-parent:38` so let me remove OpenJDK6

ppalaga commented 9 years ago

OpenJDK6 was removed from .travis.yml in 8246ff0. Only OpenJDK7 and OracleJDK8 are there now

ppalaga commented 9 years ago

@khmarbaise OK, let me add OpenJDK6 back and override mojo.java.target to 1.6

khmarbaise commented 9 years ago

I would say so...cause Maven project itself is also at Java 1.6 ? Or do you have an other opinion ?

ppalaga commented 9 years ago

Or do you have an other opinion ?

I do not think Java6 will be an obstacle for what I need.

e7b8d6c adds OpenJDK6 back and overrides mojo.java.target to 1.6

Is it acceptable like this?

ppalaga commented 9 years ago

Could please one of the project owners add the TravisCI service in https://github.com/mojohaus/xml-maven-plugin/settings/hooks so that we can see the newly added .travis.xml file in use?