search

mojohaus / xml-maven-plugin

XML Maven Plugin
https://www.mojohaus.org/xml-maven-plugin/
Apache License 2.0
23 stars 21 forks source link

Add XML formatting check Mojo #8

Closed ppalaga closed 9 years ago

ppalaga commented 9 years ago

I hope that there is a general consensus that XML plugin is the right place for a mojo checking the formating of XML files.

The present proposal is able to check spaces indentation only. Tabs and other options, such as checking trailing spaces can perhaps be added later.

The core of the implementation existed previously as a Checkstyle check https://github.com/hawkular/hawkular-build-tools/blob/master/build-tools/src/main/java/org/hawkular/build/checkstyle/xml/XmlIndentCheck.java Asking about the inclusion of the check in Checkstyle, I was told that Checkstyle is Java centric and a contribution like this would not be accepted.

Nevertheless the code was in use within Hawkular for a couple of months and can be regarded as stable and tested in practice.

ppalaga commented 9 years ago

@khmarbaise or somebody else, could you please review this PR?

ppalaga commented 9 years ago

e685d2e is a result of rebasing on top of current master and I also switched to the latest annotation conventions. Could please somebody review this PR?

ppalaga commented 9 years ago

Thanks @khmarbaise !

ppalaga commented 9 years ago

@khmarbaise, BTW, could you please name some estimate when the next release of xml-maven-plugin can be expected?