search

mojohaus / xml-maven-plugin

XML Maven Plugin
https://www.mojohaus.org/xml-maven-plugin/
Apache License 2.0
23 stars 21 forks source link

Add github report to site generation. #9

Closed khmarbaise closed 6 years ago

jochenw commented 7 years ago

Karl-Heinz, can you provide an example of what I've got to do?

khmarbaise commented 7 years ago

For example: http://www.mojohaus.org/build-helper-maven-plugin/github-report.html

jochenw commented 7 years ago

Okay, thanks!

rosslamont commented 7 years ago

Looks to me like this is now working, but the current report is not showing lots of recently closed issues, presumably because they don't have an associated milestone. I don't appear to have rights to append the milestone to those closed issues.

Also, are these changes worthy of moving to 1.1 rather than 1.0.2?

Finally, can I call a vote on a release or is that something that only committers do?

jochenw commented 6 years ago

Hi, Ross,

why did you remove the information from changes.xml?

Thanks,

Jochen

On Thu, Feb 1, 2018 at 5:56 AM, Ross Lamont notifications@github.com wrote:

Closed #9 https://github.com/mojohaus/xml-maven-plugin/issues/9 via 3491ff1 https://github.com/mojohaus/xml-maven-plugin/commit/3491ff1b692fc30499a536d6f4c1f47854fe260e .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mojohaus/xml-maven-plugin/issues/9#event-1452229641, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAaGem4UHz5emOLhQh3pu9gzJJELIkzks5tQUQAgaJpZM4G4sG_ .

rosslamont commented 6 years ago

Hi Jochen,

All that information is in the GitHub report (I only removed the 1.0.2 stuff which should be all recorded in GitHub). I checked around some other pre-github projects and it seems that people either use the changes report or the GitHub report, so I also turned off the changes report.

Personally I think keeping the changes report in, but making a clean cutover to the GitHub report has some value, but I can see that would be confusing.

Cheers Ross

jochenw commented 6 years ago

Hi, Ross,

okay, I was just asking. Lets see, how this turns out. Might be, I return to that later, because personally I am all in favour of having things in one place. (We are working on the sources anyways, and that's where changes.xml is located.)

Jochen

On Thu, Feb 1, 2018 at 11:37 PM, Ross Lamont notifications@github.com wrote:

Hi Jochen,

All that information is in the GitHub report (I only removed the 1.0.2 stuff which should be all recorded in GitHub). I checked around some other pre-github projects and it seems that people either use the changes report or the GitHub report, so I also turned off the changes report.

Personally I think keeping the changes report in, but making a clean cutover to the GitHub report has some value, but I can see that would be confusing.

Cheers Ross

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mojohaus/xml-maven-plugin/issues/9#issuecomment-362425698, or mute the thread https://github.com/notifications/unsubscribe-auth/ABAaGaS8GCdWMz6PyIlVDt8az2fichhXks5tQjy9gaJpZM4G4sG_ .