mojolicious / minion

:octopus: Perl high performance job queue
https://metacpan.org/release/Minion
Artistic License 2.0
228 stars 56 forks source link

Update to Bootstrap 5 #128

Open kraih opened 8 months ago

kraih commented 8 months ago

Similar to https://github.com/mojolicious/mojo/issues/1975, we need to update the Minion admin UI from Bootstrap 4 to 5.

rshingleton commented 7 months ago

I was considering cloning the admin plugin for an internal application that I support to eliminate the long polling and add WebSocket functionality for the live updates as well as improving the UI. I may be able to backport some of this into the AdminUI. I'll create a pull request when I get far enough along and I think it's worthwhile.

rshingleton commented 6 months ago

Some questions. I started looking at this this evening and I think the update to BS 5 won't be a huge effort. I would like to see some additional functionality on the tables for sorting and searching primarily. We use Datatables in most of our monitoring stack, but I would have to add some more dependencies and rework the jobs.html.ep quite a bit.

In our internal app I have a few custom Minion interfaces using this:

image

and a json view for extended job data. image

I've also implemented websockets to do the UI updates instead of the current long polling.

So my questions are:

I'm sure I have more questions, but I didn't want to start tearing things down too much without asking.

rabbiveesh commented 6 months ago

I would be happy to help maintain a more feature filled frontend; it would save me a lot of time bc I need to build a fuller dashboard for $work.

Though you can always just publish your own admin UI as a separate plugin

kraih commented 6 months ago

Please don't add functionality in this ticket, it is only about the Bootstrap 5 conversion. Any changes or additions would probably result in a rejection of the PR.