mojolicious / mojo

:sparkles: Mojolicious - Perl real-time web framework
https://mojolicious.org
Artistic License 2.0
2.66k stars 576 forks source link

Upgrading to Bootstrap 5 and removing dependency on JQuery. #2155

Closed sergiotarxz closed 4 months ago

sergiotarxz commented 4 months ago

Summary

Migrating to Boostrap 5 and removing dependency on JQuery.

Motivation

Issue #1975

References

1975

sergiotarxz commented 4 months ago

Screenshot from 2024-02-14 00-51-58 Screenshot from 2024-02-14 00-51-50 Screenshot from 2024-02-14 00-51-32 Screenshot from 2024-02-14 00-50-54 Screenshot from 2024-02-14 00-50-44 Screenshot from 2024-02-14 00-50-33 Right new Left Old.

sergiotarxz commented 4 months ago

Also this pull requests fixes a bug where tap for more was not changing to tap for less on click.

sergiotarxz commented 4 months ago

There is a screenshot I have not posted image

sergiotarxz commented 4 months ago

I added use strict to the javascript and discovered a bunch of errors.

sergiotarxz commented 4 months ago

I just discovered there was a code path I was not testing, I tested it and fixed the following:

I was not able to take a screenshot to tooltips working though because they depend on the mouse being over them.

sergiotarxz commented 4 months ago

@kraih Would you be in favor of moving the embedded javascript in the template to a file? Maybe in another pr.

kraih commented 4 months ago

@kraih Would you be in favor of moving the embedded javascript in the template to a file? Maybe in another pr.

Can't say, would depend on how clean the resulting code ends up.