Open kraih opened 11 years ago
I've been thinking about this a bit, and i believe a new layer (Mojo::Channel
?) between connection management and high level transactions would make adding new protocols and dealing with multiplexing a lot easier.
Mojo::UserAgent -> Mojo::Channel::HTTP::Client -> Mojo::Transaction::HTTP
-> Mojo::Channel::WebSocket::Client -> Mojo::Transaction::WebSocket
Mojo::Server::Daemon -> Mojo::Channel::HTTP::Server -> Mojo::Transaction::HTTP
-> Mojo::Channel::WebSocket::Server -> Mojo::Transaction::WebSocket
Channels could combine all client_*
and server_*
methods from the transaction classes with the transaction management code of the user agent and daemon.
A good first step might be to move the transaction management code from Mojo::UserAgent
to Mojo::Channel::HTTP::Client
and Mojo::Channel::WebSocket::Client
, that should be enough to figure out the right API and cause no backwards compatibility issues.
+1
:+1:
The current version of the HTTP/2 spec terrifies me, think we'll wait with this as long as we can.
I believe the original Mojo::Channel
plan might also have also been a bit too ambitious, better start with something that fits into the current architecture, and work on abstraction once we have more experience.
The HTTP/1 upgrade mechanism can be ignored completely, browser vendors are not going to implement that (Firefox and Chrome have confirmed this in the working group), only valid handshake for negotiating HTTP/2 will be TLS with ALPN/NPN. So IO::Socket::SSL
and a modern version of OpenSSL will be hard requirements.
Working Group Last Call. http://lists.w3.org/Archives/Public/ietf-http-wg/2014JulSep/1563.html
We need more volunteers to work on this.
I can help!
The plans i've outlined above were a bit too ambitious, that extra layer of abstraction is not really necessary. I think a good first step would be to start with a prototype, using an existing implementation of the HTTP/2 protocol (perhaps Protocol::HTTP2). Then the focus can be on getting protocol negotiation right, with NPN/ALPN in Mojo::IOLoop::Client
/Mojo::IOLoop::Server
, and HTTP1/HTTP2 in Mojo::UserAgent
/Mojo::Server::Daemon
.
I'm actually not too concerned about the actual protocol implementation, that seems pretty straight forward, and more about the integration into our existing architecture.
Since browsers like Chrome already support HTTP/2, i think a good first milestone would be to add NPN/ALPN support to Mojo::IOLoop::Server
with IO::Socket::SSL, and then just enough Protocol::HTTP2 glue code to Mojo::Server::Daemon
for basic request/response handling.
:+1:
I don't familiar with Mojo internals, but i tried to implement glue code https://github.com/vlet/mojo/tree/vlet/http2-hacks Protocol::HTTP2 API is not stable yet, so there is a opportunity to change it in a way, that will be convenient for Mojo
@vlet Thanks, that's a pretty decent proof of concept. The PSGI step should be avoided though, and the response might not be available right after the request
event has been emitted (non-blocking operations in progress).
Up ;) Would be great to have this implemented :)
This feature depends on #876.
This feature also depends on #888.
Perhaps I'm naive, but I feel like if Mojolicious was first or among the first to release HTTP/2 support that it might help it to gain some attention and even many more new users.
Sadly we are already pretty far behind with this.
Honestly, i think unless we find a sponsor for this feature, it will take a very long time to get it production ready.
I imagine this might become a bigger topic once there are HTTP/2 only servers on the web, and folks want to access them with Mojo::UserAgent
.
What is needed from a sponsor? I don't have a ton of connections but I'd be happy to spread the word as best I can, as I already do for Mojolicious. Everyone in St. Louis, MO, USA is at least now aware that Mojolicious exists and is the greatest thing since sliced bread. :D
I'd also like to get my employer involved, so there's that...
Is there anything more that a sponsor can do than provide money? How much money? What is the process for this? Is there perhaps a not-for-profit entity for the purpose of tax deductible contributions (in the USA and/or otherwise)? I could look into establishing a not-for-profit organization in the USA if interested, I'm unaware at this point what the requirements of it are.
What would be the timeline to release a first version of this branch?
Realistically, i think it would take a good full-time programmer between 6 and 12 months to finish this feature. Currently there is no formal process, but if one or more interested companies step up, i'm sure we can change that pretty quickly.
There are a few milestones to reach, 1) protocols like HTTP/1.1 and WebSockets need to become pluggable (#876), 2) we need ALPN protocol negotiation (#888), 3) proof of concept implementation of the HTTP/2 protocol with an existing CPAN module like Protocol::HTTP2, 4) optimized custom implementation of the HTTP/2 protocol, 5) advanced features such as stream prioritization and server push.
After the very successful hackathon last weekend, i think 6 months is a very realistic timeframe.
For learning more about HTTP/2, i recommend these two free ebooks.
https://www.nginx.com/http2-ebook/ http://daniel.haxx.se/http2/
:+1: Thanks for the links!
I would be happy to sponsor some dev time towards this.
ALPN support is done (#888), and pluggable protocols almost finished too (#876). I think a proof of concept HTTP/2 implementation might be possible now.
We do not have anyone from the core team working on this though, and need volunteers. My current estimate for reaching milestone 4 with a full-time programmer would be 2-3 months.
In the meantime, you can of course deploy Mojolicious applications with a reverse proxy that supports HTTP/2, such as NGINX. https://www.nginx.com/blog/nginx-1-9-5/
Is anyone working on the proof of concept implementation? What does it involve? How do I start?
The RFC8030 "Web Push" protocol (to send notifications to devices even while browsers are not necessarily running) is one of the first that is starting to require HTTP/2 for at least part of its implementation:
If receipt messages are not required, then it should theoretically be possible to implement Web Push using just HTTP/1.1. However, the protocol requires a server known to the user agent, with defaults for those builtin to user agents; at some point it's going to be reasonable to assume for those servers that no application server is ever going to talk to them that doesn't support HTTP/2, and then this becomes a hard dependency.
Been some time since we last updated this issue. I think the approach with channels was wrong, and should be abandoned. Instead it might be better to start from the low level side, and create a few Mojo::IOLoop::Stream subclasses with code extracted from Mojo::Server::Daemon
and Mojo::UserAgent
.
Mojo::Server::Daemon -> Mojo::IOLoop::Stream::HTTPServer
Mojo::IOLoop::Stream::WebSocketServer
Mojo::UserAgent -> Mojo::IOLoop::Stream::HTTPClient
Mojo::IOLoop::Stream::WebSocketClient
Big advantage of that approach is that those classes can be implemented parallel to everything we have now, usable and testable on their own. And once they work we can just reimplement Mojo::Server::Daemon
and Mojo::UserAgent
using those stream classes (hopefully with a lot less code).
Regarding the API, there are many options and i'm open to all suggestions, but to give you an idea for how it could look here's a Mojo::IOLoop::Stream::HTTPServer
example.
Mojo::IOLoop->server({port => 8080, stream_class => 'Mojo::IOLoop::Stream::HTTPServer'} => sub {
my ($loop, $stream) = @_;
$stream->on(request => sub {
my ($steam, $tx) = @_;
my $method = $tx->req->method;
my $path = $tx->req->url->path;
$tx->res->code(200);
$tx->res->headers->content_type('text/plain');
$tx->res->body("$method request for $path!");
$tx->resume;
});
});
And one for Mojo::IOLoop::Stream::HTTPClient
. Here i'm less sure about the actual API, but you get the idea.
my $tx = Mojo::UserAgent::Transactor->new->tx(GET => 'http://mojolicious.org');
$tx->on(finish => sub {
my $tx = shift;
say $tx->res->code;
});
Mojo::IOLoop->client({port => 8080, stream_class => 'Mojo::IOLoop::Stream::HTTPClient'} => sub {
my ($loop, $err, $stream) = @_;
$stream->process($tx);
});
The server is a lot easier than the client, so it would make sense to start there. How exactly the WebSocket upgrade is supposed to work, i'm not sure yet, but that can be added later, once HTTP works.
I've just started work on this :)
Thanks to #1227 we've made a big leap forward. HTTP/2 support can now be developed separately from Mojo::UserAgent
and Mojo::Server::Daemon
as Mojo::IOLoop::Stream::HTTP2Client
and Mojo::IOLoop::Stream::HTTP2Server
, which will make testing a lot easier.
ALPN is now also very easy to use with Mojo::IOLoop
. https://github.com/kraih/mojo/commit/c838dd15dc74d02513624271d06046120581f831
And just a quick reminder. If anyone here decides to implement Mojo::IOLoop::Stream::HTTP2Client
and/or Mojo::IOLoop::Stream::HTTP2Server
with Protocol::HTTP2. Please do not use those names to release it to CPAN, we do want to use them for core Mojolicious.
Unfortunately the addition of stream classes caused big problems and had to be reverted. https://github.com/kraih/mojo/commit/61f6cbf22c7bf8eb4787bd1014d91ee2416c73e7 Hopefully there will be another attempt with less race conditions and a clearer connection life cycle.
I guess we might as well skip HTTP/2 now and implement HTTP/3 instead. 😆
Edit: Some people did not get that this was a joke. It was.
Time for an update. The landscape has changed a bit and we now know that HTTP/2 and HTTP/3 are mostly pointless for our web server. So it would make sense to focus on Mojo::UserAgent
support. Through an XS binding for nghttp2.
Should the http/2 support respect the proxy settings at IO::Socket using nghttp2?
Should the http/2 support respect the proxy settings at IO::Socket using nghttp2?
If there are multiple solutions then i'd always be in favour of the one that results in the simplest code.
The final HTTP/2 spec is still at least 1-2 years away, but now that the first draft (based on SPDY) has been released, i believe we can at least start planning our implementation.
http://tools.ietf.org/html/draft-ietf-httpbis-http2-00
While details like the upgrade mechanism from HTTP/1.1 and mandatory TLS encryption are very likely to change, major features like multiplexing are pretty much a given, and will require some refactoring in Mojolicious.