Closed dmanto closed 3 years ago
Opening a second PR feels like you're dismissing all my previous reviews. I've tried very hard to tell you exactly what i expect from this feature. And you still do the opposite intentionally (as illustrated by comments). I don't think both of us want the same from this module, so perhaps you would be better off just releasing your own Windows specific one instead.
Normally i would flag this PR as work in progress and wait for your response/changes, but since you close those anyway i'll do the same now.
This should fix all pending claims from your review. Rebased from new master branch (PR#1 was based on windows branch, that's why I closed it and created this new one).
Related to issue #1