mojolingo / sippy_cup

Create SIP load test scenarios the easy way
http://mojolingo.github.io/sippy_cup
MIT License
219 stars 78 forks source link

Robust dtmf packets #103

Closed aukeman closed 5 years ago

aukeman commented 5 years ago

Made some changes to how RFC 2833 DTMF digits are generated so packets emitted adhere more precisely to the spec and so they are more reliably interpreted on the receiving side.

Things done:

As a point of reference, the generated digits closely match what is emitted by Twilio SIP trunks, and are being far more reliably interpreted by the SIP server i'm running (freeswitch 1.6.20)

bklang commented 5 years ago

Looks great! Thank you for the contribution and for updating the tests.