search

mojolingo / sippy_cup

Create SIP load test scenarios the easy way
http://mojolingo.github.io/sippy_cup
MIT License
219 stars 78 forks source link

Miscellaneous features and such #18

Closed wdrexler closed 11 years ago

wdrexler commented 11 years ago

In the past, SippyCup would throw an error any time a call failed. I've suppressed this error for now. Also, added support for (optional) static RTCP ports. @polysics has created a stop method and changed the way SIPp gets run from SippyCup.

benlangfeld commented 11 years ago

This also needs support for mapping @options[:inf_csv] to -inf.

wdrexler commented 11 years ago

That completely slipped my mind, thanks for pointing that out :)

wdrexler commented 11 years ago

Added -inf, as well as swapped the calls to #p with an instance of Logger that can be passed in from the outside. @benlangfeld, thoughts?

benlangfeld commented 11 years ago

We have had problems with variables being named things like file, and csv. This is not an informative naming strategy, so I would be very much against the latter.

From the SIPp docs:

   -inf             : Inject values from an external CSV file during calls into
                      the scenarios.
                      First line of this file say whether the data is to be
                      read in sequence (SEQUENTIAL), random (RANDOM), or user
                      (USER) order.
                      Each line corresponds to one call and has one or more
                      ';' delimited data fields. Those fields can be referred
                      as [field0], [field1], ... in the xml scenario file.
                      Several CSV files can be used simultaneously (syntax:
                      -inf f1.csv -inf f2.csv ...)

How about something like :scenario_variables?

bklang commented 11 years ago

scenario_variables is fine with me. We'll need to document that its parameter is expected to be a semi-colon delimited file.

benlangfeld commented 11 years ago

Is it worth supporting multiple files?

bklang commented 11 years ago

Not until someone provides a good use-case for that. Since we are providing all the inputs via YAML let's start by supporting the simple/common cases.

wdrexler commented 11 years ago

Alright, I'll make the RTCP port specifiable and change the CSV variable name

wdrexler commented 11 years ago

This should be better, @bklang, look good to you?

bklang commented 11 years ago

Need to document (in the README) the behavior and availability of :scenario_variables and the new RTCP port parameter. Other than that, good to go.