search

mojolingo / sippy_cup

Create SIP load test scenarios the easy way
http://mojolingo.github.io/sippy_cup
MIT License
218 stars 78 forks source link

Feature/better error handling #22

Closed lpradovera closed 11 years ago

lpradovera commented 11 years ago

This is to temporarily handle other errors while we figure out how to detect them.

lpradovera commented 11 years ago

We do not know what 255 means, SIPp uses it for any unexpected error, so we need to capture the message in addition to the type.

bklang commented 11 years ago

Luca, this PR seems to have some strange commits in here, like my merge for #19 and the now-stale CHANGELOG updates. Can you squash?

lpradovera commented 11 years ago

Cleaned up commit tree.

lpradovera commented 11 years ago

quietly (http://guides.rubyonrails.org/active_support_core_extensions.html#silencing-warnings-streams-and-exceptions) comes from ActiveSupport and is quite handy. It silences all standard output types. I use it here because otherwise we would be seeing the error printed out over and over.

benlangfeld commented 11 years ago

@bklang Please merge.