search

mojolingo / sippy_cup

Create SIP load test scenarios the easy way
http://mojolingo.github.io/sippy_cup
MIT License
219 stars 78 forks source link

Brew install sipp doesnt not install w/ pcap support by default #44

Closed johntdyer closed 10 years ago

johntdyer commented 10 years ago

so I realize this may be considered a homebrew issue but I figured I would open a ticket here incase anyone else ran into this problem. It seems the the current sipp homebrew foruma does not install w/ pcap support. 

jdyer@retina:~/Projects/sippy_cup » sippy_cup -cr test.yml
Compiling media to /Users/jdyer/Projects/sippy_cup/test.xml...done.
Compiling scenario to /Users/jdyer/Projects/sippy_cup/test.pcap...done.
I, [2013-11-15T09:35:41.786656 #2422]  INFO -- : Preparing to run SIPp command: sudo sipp -i 10.6.96.92 -p 8836 -sf /Users/jdyer/Projects/sippy_cup/test.xml -l 1 -m 1 -r 1 -s 9991xxxxx 10.6.69.188
2013-11-15  09:35:41:800    1384526141.800288: play_pcap_audio requires pcap support! Please recompile SIPp.
I, [2013-11-15T09:35:41.801057 #2422]  INFO -- : Test completed successfully!

So I was thinkMaybe you guys should mention this in the readme ? I was able to fix this using the following formula

require 'formula'

class Sipp < Formula
  homepage 'http://sipp.sourceforge.net/'
  url 'http://downloads.sourceforge.net/project/sipp/sipp/3.4/sipp-3.3.990.tar.gz'
  sha1 'b2637cb72556595253bbdd4a68cc974c9ac1d92e'
  def install
    system "./configure", "--with-pcap"
    system "make", "DESTDIR=#{prefix}"
    bin.install "sipp"
  end
end
dgershman commented 10 years ago

Yeah i had the same issue. Did you make a pull request for this on homebrew?

johntdyer commented 10 years ago

No, I suck and didn't. I'll do it tonight

dgershman commented 10 years ago

+1

johntdyer commented 10 years ago

Sorry, just got to this now... I also added support for openssl

johntdyer commented 10 years ago

Sorry, just to be clear, this is an option in the formula, not the default. So the instructions for sipp should probably be updated. 

brew install sipp --pcap
dgershman commented 10 years ago

Yeah I think that is the right Approach

Danny

On Feb 13, 2014, at 10:39 PM, John Dyer notifications@github.com wrote:

Sorry, just to be clear, this is an option in the formula, not the default. So the instructions for sipp should probably be updated.

brew install sipp --pcap — Reply to this email directly or view it on GitHub.

johntdyer commented 10 years ago

@vindir - You guys going to handle the doc update ?

johntdyer commented 10 years ago

Looks like the homebrew guys wants pcap enabled by default, so I guess no update of the docs will be required once this is merged

johntdyer commented 10 years ago

Looks like the PR was merged

bklang commented 10 years ago

Nice work. Thank you @johntdyer!