search

mojolingo / sippy_cup

Create SIP load test scenarios the easy way
http://mojolingo.github.io/sippy_cup
MIT License
218 stars 78 forks source link

Fix specs under ActiveSupport 4 #81

Closed chewi closed 9 years ago

chewi commented 9 years ago

capture and quietly are deprecated because they are not thread-safe. That does not matter for these specs and the former is required for some tests so import the code from ActiveSupport. The latter isn't strictly required but we might as well bring that across too.

Since we have a global around block to apply quietly, the individual invocations of it are not necessary.

chewi commented 9 years ago

That's odd, the tests all pass under Ruby 2.2.0 here. @benlangfeld, could you please try these yourself?

benlangfeld commented 9 years ago

All tests pass locally for me and these failures occurred prior to this change in CI.