mojolingo / sippy_cup

Create SIP load test scenarios the easy way
http://mojolingo.github.io/sippy_cup
MIT License
218 stars 78 forks source link

set event end flag for dtmf digits #99

Closed aukeman closed 6 years ago

aukeman commented 6 years ago

RFC 2833 DTMF digits don't currently get emitted with the media stream (at least as of SIPp 3.5.1) because the end-of-event flag isn't set due to an off-by-one error when generating packets.

This PR fixes the off-by-one error and adds a test to ensure that the flag is in the last packet generated for a digit.

lpradovera commented 6 years ago

Very cool, thank you!

aukeman commented 6 years ago

any chance of a new release containing this change any time soon?