Rewrite Handlers, Repeaters and improve Tagging

davispuh commented 7 years ago

Continuation of #278 (that was closed because it was sent to beta branch which is now merged in master and removed). Work still in progress.

bramski commented 6 years ago

Open forever. Along with a lot of other pull requests. What's the deal?

davispuh commented 6 years ago

See #316 Haven't had time to be done with this, but should be soonish.

MatMoore commented 6 years ago

@davispuh is this something other people can help with? I have some free time over the christmas period and would be happy to contribute if I can.

What's your plan for getting this released as a new version? Do you need @leejarvis to actually release a new gem version? As I understand it, there are already a lot of changes on master that aren't published on rubygems, including your 2014 PR - what's blocking this?

davispuh commented 6 years ago

I'm not sure but I think yeah.

This is what is left to do:

Rewrite TimezoneParser to switch from Marshal to SQLite, I've been working on this when I have time. It's needed to improve performance. I just pushed my unfinished wip branch. I don't think I'll have time to work on it this month.
Add Region and Locale (default en) parameters to Chronic so they're passed to TimezoneParser, no need to try parse other languages/locales by default.
Not that important, but I wanted to implement timezone name and zone parsing, like 15:00 Eastern Standard Time and 15:00 Europe/London. (see lib/chronic/tags/time_zone.rb and lib/chronic/time_zone.rb)
Go over all GitHub issues and see which are fixed and if not then fix them.
Go over all GitHub pull requests and see which ones could be reimplemented on top of rewrite.
Write change notes in HISTORY.md since last release till master, then write from master till rewrite.

There's nothing really blocking it, just it haven't been done. Basically need write HISTORY.md then release 0.11.0, then merge this PR and release 1.0.0. And yeah @leejarvis will have to push it to RubyGems since I don't have such access.

MatMoore commented 6 years ago

Cool, I'll see what I can do.

I think I'll hold off on the first 3 things (at least until I'm more familiar with the codebase), but I'll have a look through the open issues and see if I can write some tests for them. Then if I find issues that are fixed on master or rewrite I can make a note of that for the changelog.

mojombo / chronic

Rewrite Handlers, Repeaters and improve Tagging #347