search

mojombo / chronic

Chronic is a pure Ruby natural language date parser.
http://injekt.github.com/chronic
MIT License
3.23k stars 452 forks source link

Document unreleased changes #372

Closed MatMoore closed 6 years ago

MatMoore commented 6 years ago

Lots of fixes have made their way into master but haven't been released yet.

I've added a section to the changelog for unreleased changes, so we just have to fill in the version number and date when releasing the next version.

I think these open issues are fixed on master:

davispuh commented 6 years ago

Thanks, looks great! 👍 is this all? like I mean if nothing is missing. Also do you see if there's anything else that should be fixed/merged in for this release? if not we might aswell just release this as 0.11.0 and then next one would be with rewrite merged in.

MatMoore commented 6 years ago

This is all I could find by going through the closed PRs one by one and ignoring the ones that looked like refactoring. It may be worth someone more familiar the code reviewing the diffs, in case I missed something.

Of the open issues, I'd prioritise any where chronic crashes or returns garbage instead of nil, excluding the ones which should be fixed on rewrite. Particularly the ones where it returns inconsistent results depending on the current date.

This one also seems quite bad but looks like a bigger issue to me (chronic ignoring context in day portions)

I haven't looked at any of the open PRs in detail, but the only one I'd consider merging now is https://github.com/mojombo/chronic/pull/307 (although it's lacking tests at the moment). A lot of the others are adding new features or localisation.

I don't think any of these should delay getting another version out though - master still looks a whole lot better than the previous release. 🙂

MatMoore commented 6 years ago

Closing for now as I'm not sure what needs to happen with this. Feel free to reopen if this is useful.