search

mojombo / mustache.erl

Mustache template engine for Erlang.
MIT License
239 stars 59 forks source link

Fix true and false matching #8

Closed pusewicz closed 12 years ago

pusewicz commented 12 years ago

@tuncer: Can you please review?

pusewicz commented 12 years ago

@tuncer ping

MattVonVielen commented 12 years ago

@tuncer double-ping!

ghost commented 12 years ago

If it doesn't break existing templates and fixes the bug, +1.

hukl commented 12 years ago

So how about merging it in and restoring the functionality of this library? This is a super annoying bug. For now I'm using https://github.com/asynchrony/mustache.erl sigh

ghost commented 12 years ago

ping

MattVonVielen commented 12 years ago

There is a possibility of this change breaking some templates somewhere (in addition to fixing the example templates in mustache.erl itself) - it is now essentially impossible to make a template that renders the values "true" and "false", which must be the reason behind the original breaking change that started this.

Someone mentioned to me that riak uses mustache for something, and since I've never used riak much less looked at its code, I'm not at all the right person to ask whether this breaks it.

hukl commented 12 years ago

I'd much rather have a working feature for 99.999999% of the case than the other way around. In the meantime we have created our own fork, pulled in the fixes and have a working template lib.

pusewicz commented 12 years ago

Merged.