search

mojotech / json-type-validation

TypeScript JSON type validation
MIT License
155 stars 15 forks source link

Add tuple decoder #32

Closed r-k-b closed 5 years ago

r-k-b commented 5 years ago

This adds support for decoding tuples, as mentioned in #31.

Not 100% sure this uses the most appropriate solution; feedback welcomed!

r-k-b commented 5 years ago

Thanks for the feedback! I've updated the PR, including the updated docs.

As for squashing it all into a single commit, is that not an option when merging? I'm not confident in doing a squash from my end; wouldn't that mess with the commits I've already pushed & you've commented on?

mulias commented 5 years ago

I've never noticed before that squash and merge is an option 👍 I'll check this out tomorrow, thanks.

mulias commented 5 years ago

This looks good, thanks @r-k-b