search

mojotech / pioneer

Integration Testing
MIT License
526 stars 35 forks source link

Upgrade Cucumber from 0.3.3 to 0.4.4 #268

Open patoi opened 10 years ago

patoi commented 10 years ago

It is working with Cucumber 0.4.4: npm install cucumber, but it throws an exception with 

"format": "pioneerformat.js"

If I change this one to 

"format": "pretty"

than it works fine.

samccone commented 10 years ago

@patoi we are using an older version of cucumber on purpose.

Since cucumber updated their coffeescript compiler the stack traces that you get back from cucumber have become useless.

We have also applied a few patches on top of cucumber to allow for custom formatters.

Is there something you want from the never version of cucumber?

sullenboom commented 10 years ago

@samccone : Thanks for the information. I had the same question.

You ask about a needed feature. We need for our tests "scenario outline" from cucumber v.4+. When do you think it is implemented at pioneer?

aindlq commented 9 years ago

Any news on this issue, "scenario outline" could be really useful. But new cucumber is required for this feature.

aindlq commented 9 years ago

fyi, I've tried pioneer with latest cucumberjs and "format": "pretty". It works great. "scenario outline" works out of the box. And as for me stack trace is not bad at all.

For everyone who are using pioneer and need "scenario outline" feature from latest cucumumber, you can just use npm shrinkwrap to override cucumberjs version - https://docs.npmjs.com/cli/shrinkwrap

samccone commented 9 years ago

hey @artemkozlov yeah this was using an old version because of stack traces and custom formatters, and promise returns. If you think everything is working would you like to open a PR?

aindlq commented 9 years ago

@samccone I can do that. Should we wait for https://github.com/cucumber/cucumber-js/pull/309 to land, to get rid off cucumberjs fork?