search

mojotech / pioneer

Integration Testing
MIT License
527 stars 35 forks source link

Update use of form widget constructor. #311

Closed ziagrosvenor closed 9 years ago

ziagrosvenor commented 9 years ago

Form widget is extended before new instance is created.

samccone commented 9 years ago

hi @ziagrosvenor thanks for the PR.

What is the gain here in your opinion?

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 89.38% when pulling 1d09afbd643e56ddbc42d39152fabe0a735665b8 on ziagrosvenor:patch-1 into 98a25229feaba5e8cebf1d57bfb1b0147f5de449 on mojotech:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 89.38% when pulling 1d09afbd643e56ddbc42d39152fabe0a735665b8 on ziagrosvenor:patch-1 into 98a25229feaba5e8cebf1d57bfb1b0147f5de449 on mojotech:master.

ziagrosvenor commented 9 years ago

hi @samccone, pioneer is super cool! I have found the submitWith() method doesn't work when following the docs. Another person had this same issue also - https://github.com/mojotech/pioneer/issues/285