search

mojotech / pioneer

Integration Testing
MIT License
527 stars 35 forks source link

Support cucumber AND/OR tags properly #335

Open tomhicks-bsf opened 9 years ago

tomhicks-bsf commented 9 years ago

Multiple tags should be supplied in multiple --tags arguments, which allows logical ORs and ANDs to be applied to tags. This creates --tags arguments according to the cucumber docs:

https://github.com/cucumber/cucumber/wiki/Tags

tags: ['@one', '~@two'] will run scenarios with tag @one, but not scenarios with tag @two.

tomhicks-bsf commented 9 years ago

Fixes #334

sethkrasnianski commented 8 years ago

Looks good :+1:. :eyes: @samccone?

samccone commented 8 years ago

sure thing

mAiNiNfEcTiOn commented 8 years ago

You gotta be kidding me... I have a PR to fix this since July (https://github.com/mojotech/pioneer/pull/335) ... :/

Oh well...

tomhicks-bsf commented 8 years ago

sorry, I didn't check that before opening this. EIther way, neither has been merged! How do we get pioneer support up and running again?

mAiNiNfEcTiOn commented 8 years ago

Yeah... good question ... :P @samccone might be super busy, but I have been using this project for quite a while (we have this on our CI)...

But due to this lack of support/maintenance I am very inclined to switch to other solutions (such as nightwatch) which have far more contributors, stars, and supporters.

Doesn't have gherkin... but I guess that is easily implementable :)

Oh, and no need to be sorry ... Just found interesting that you had feedback on the PR :P

samccone commented 8 years ago

Hey @mAiNiNfEcTiOn and @tomhicks-bsf I actually no longer work at this company and do not use this project anymore

perhaps @sethkrasnianski could help here :eyes: