search

mojotech / social-builder

MIT License
57 stars 11 forks source link

add support for https://github.com/carrot/share-button #39

Open samccone opened 10 years ago

samccone commented 10 years ago

would love to be able to make these work together.

I think we can get away without using the JS if we just manually do an inline 

onClick="toggleClass()"

and use our own social button images

cc @jenius @ryancoughlin

jescalan commented 10 years ago

Inline javascript?

samccone commented 10 years ago

yeah just a tiny bit, so that people do not need any external js.

jescalan commented 10 years ago

You want external js. I mean, you have to assume people using this tool also want clean code that they want on their site... if you are working with a js plugin, you want control of it.

ryancoughlin commented 10 years ago

Isnt the carrot builder all CSS anyway?

On Mon, Jan 27, 2014 at 10:02 PM, Jeff Escalante notifications@github.comwrote:

You want external js. I mean, you have to assume people using this tool also want clean code that they want on their site... if you are working with a js plugin, you want control of it.

— Reply to this email directly or view it on GitHubhttps://github.com/mojotech/social-builder/issues/39#issuecomment-33447330 .

samccone commented 10 years ago

the JS takes care of the generation and the toggle active behavior as well as opening the link

but the only real thing we need to emulate is the active toggle which... is simple