Https and license - Githubissues

mojotech / social-builder

MIT License

57 stars 11 forks source link

Https and license #46

Closed IonicaBizau closed 9 years ago

IonicaBizau commented 9 years ago

Use https instead of http. Fixes #44. I avoided to use // since it will brake the local page.
Renamed the readme.md file into README.md. Also, cleaned up the markdown and added a link to the license file.

I'm using this tool for the Bloggify social plugin, which is open-source here.

You can see it in action on my website. :smile:

IonicaBizau commented 9 years ago

I'm not sure how should I generate the gh-pages files... /cc @samccone @sethkrasnianski

samccone commented 9 years ago

no worries I will deploy that for you :)

IonicaBizau commented 9 years ago

:bulb: pro tip: comment on the File changed page instead of commenting on my commits, because doing so when I will delete my fork they will disappear. Also, I have edit privileges on your comments on my commits (since I'm the fork owner). :sunglasses:

IonicaBizau commented 9 years ago

/cc @samccone

samccone commented 9 years ago

great testing locally

samccone commented 9 years ago

:clap: thanks so much

IonicaBizau commented 9 years ago

You're welcome! Seems it's already working on GitHub Pages, but not yet on mojotech.com. :+1:

samccone commented 9 years ago

yeah, so it looks like the images that we are inlining are messed up and defaulting to http still, I think it might end up being a JS fix as well

screen shot 2015-03-13 at 12 02 11 pm

so github is still throwing the issue, but since we are not in an iframe we are able to still see the page