search

mojotech / torch

A rapid admin generator for Elixir & Phoenix
Other
1.12k stars 80 forks source link

Look into migrating from Scrivener to Flop #479

Open cpjolicoeur opened 2 months ago

cpjolicoeur commented 2 months ago

Scrivener/Scrivener_Ecto are in low maintenance mode and no longer being updated/supported.

https://github.com/woylie/flop https://github.com/woylie/flop_phoenix

UPDATE

We have taken over maintenance of Scrivener and Scrivener.Ecto so this should be exploratory. If it makes sense to transition to Flop and keep Scrivener in low maintenance mode, we should look into it. Otherwise, we can/should do some updates on Scrivener and take it out of low maint mode.

adamu commented 2 months ago

A temporary option could be to use a fork of Scrivener in the mean time, for example to apply this PR which would unblock people using Torch from updating to Ecto 3.12.0.

https://github.com/drewolson/scrivener_ecto/pull/105

cpjolicoeur commented 2 months ago

Yeah, we should this in the short term for sure to unblock people currently blocked.

cpjolicoeur commented 2 months ago

@adamu Torch v5.3.2 was published that includes a hex package fork of scrivener ecto with the PR you linked to applied. Any chance you could vet that this fixes any blockers for Ecto 3.12.0+?

adamu commented 2 months ago

@cpjolicoeur Can confirm I was able to deploy this Torch version alongside Ecto 3.12.3. Pagination looks ok, too.

It appears the hexdocs are broken again, though.

cpjolicoeur commented 2 months ago

@adamu Thanks for confirming that. I'll look into the broken docs. I'm not sure why it keeps breaking on the hex.pm published docs when things compile fine for me locally. I'll look into it and fix though. Appreciate it.

BTW,

cpjolicoeur commented 2 months ago

@adamu Docs should be updated I think.