search

mokasin / apw

Small and simple Awesome WM widget to control volume of Pulseaudio.
37 stars 33 forks source link

Fix show_text mode by using wibox.layout.stack #22

Closed balderdash closed 7 years ago

balderdash commented 7 years ago

If like me you had set show_text = true on line 29, the widget layout broke in the upgrade from Awesome 3.x to 4.1, with the widget taking up almost the entire width of the screen. This PR fixes show_text mode by using wibox.layout.stack instead of doing any custom widget stacking, and deletes the now-unused make_stack().

balderdash commented 7 years ago

This fixes https://github.com/mokasin/apw/issues/21

mokasin commented 7 years ago

Am I crazy or is the diff the wrong way around?

balderdash commented 7 years ago

This PR switches from the existing custom implementation of widget stacking to using the standard awesomewm offering, so the diff should be mostly deleted lines. Are you seeing something different?

mokasin commented 7 years ago

Ah, my bad. Just couldn't remember the make_stack function was added.

Thx for your contribution!