search

mokasin / apw

Small and simple Awesome WM widget to control volume of Pulseaudio.
37 stars 33 forks source link

Added margins to widget. #6

Closed Goffredo closed 10 years ago

Goffredo commented 10 years ago

Modified the widget so that margins can be specified. It seems to be the only way to set the height of the widget. If needed I can also update the readme.

mokasin commented 10 years ago

The awful API certainly lives up to its name.

I'm thinking about exposing the configuration variables somehow to the rc.lua. But it's definitly a good idea to mention customisability in the README.

Thx!

Goffredo commented 10 years ago

Should I mention colors in the Customize part? I see that another pull request is kind of managing that part, right?

mokasin commented 10 years ago

Be my guest :).

Goffredo commented 10 years ago

Ah ok, well lets say i'll mention colors when you merge the Beautiful integration, ok?

mokasin commented 10 years ago

On a second thought: If you have written something already, just mention the margin stuff in the README. So it doesn't get mixed up.

But propably just a hint in the README that some customizations are possible in widget.lua and the comments in the source will do. It is pretty self explanatory, I think.

mokasin commented 10 years ago

Yeah, just leave it. Thank you!

Goffredo commented 10 years ago

ok, not to bother any further, but should I push a different commit with the hints in the readme?

mokasin commented 10 years ago

No, thx. :+1: I'll come up with something, when the beatiful pull request is merged.