search

mokasin / apw

Small and simple Awesome WM widget to control volume of Pulseaudio.
37 stars 33 forks source link

Pull request question #7

Closed Goffredo closed 7 years ago

Goffredo commented 10 years ago

Hi, I've added another little feature to the widget. But I actually committed it before I pulled from the new Beautiful integration. So how do I submit a pull request now? Should I merge it first or just send a pull request and let you merge it manually?

mokasin commented 10 years ago

Probably the cleanest way is to rebase your commit(s) onto master before filing the pull request.

No need to do a local merge, as that would be redundant if master moved along. In that case I had to merge it anyways.

Goffredo commented 10 years ago

Ok, I think I managed to rebase, also any advice for the commit messages?