mokhosh / filament-jalali

Add Jalali datetime to your filament apps
MIT License
28 stars 2 forks source link

[Bug]: correct direction of inputs in time picker #9

Closed imami closed 1 week ago

imami commented 3 weeks ago

What happened?

In jalali-date-time-picker.blade.php#L208

the rtl:flex-row-reverse class is used which causes the time picker's inputs displays in a reversed direction which is wrong!

having rtl:flex-row-reverse class:

image

without rtl:flex-row-reverse class:

image

I personally prefer the direction of Hours:Minutes:Seconds to be always LTR, even if the page direction is RTL.

Also the rtl:flex-row-reverse seems better to be removed on the official DateTimePicker component.

How to reproduce the bug

DateTimePicker::make('test_date')->jalali(),

Package Version

3.3.0

PHP Version

8.3.7

Laravel Version

11.20.0

mokhosh commented 3 weeks ago

Hey,

I couldn't reproduce this bug. Do you mind creating a reproduction repo?

This is how it currently renders in my apps:

Screenshot 2024-08-17 at 15 12 43