search

mokhosh / filament-kanban

Add kanban boards to your Filament pages
https://filamentphp.com/plugins/mokhosh-kanban
MIT License
228 stars 32 forks source link

Customizable Card Title & Content #7

Closed mkwsra closed 6 months ago

mkwsra commented 6 months ago

You can feel free to not merge this PL, this is what I did:

Thanks for this Plugin ya bro.

BTW @waelkhalifa and I were parallel-programming these changes to have some excited hours 🙌 Thanks to you Mo

mokhosh commented 6 months ago

Salaam @mkwsra and thank you for putting the time and thought into this PR.

It is currently possible to customise the card title and content, however, the concerns of data layer and presentation layer are separated. You can override the transformRecords method to pass as much data as you need to your view. And you can publish the views and add as much html, css, and php code as you need for your card.

Anything more than a title and a status shouldn't be absolutely necessary for the most basic form of a Kanban Board.

You can see a visual example of how it's being customised with the current architecture, in the OP of this PR: https://github.com/mokhosh/filament-kanban/pull/3

Here are a few suggestions I have for your future PRs:

  1. Never open a PR from your main branch. Always create a feature branch. Otherwise you can't open another PR until the first one is merged, and even when it is merged you cannot pull from upstream because your main brach will have conflicts.
  2. Open separate PRs for separate issues. For example you have made some good changes to the README here, that I would be more open to merging, if they weren't bundled with unrelated commits.
  3. Try to match the style of the codebase as closely as possible. As you can see I'm avoiding PHPDoc comments, and using native php types. Also I'm never using mixed as a type.

Let me know if you want to make a separate PR just for the docs, or I should go ahead and add clarifications myself.

Thank you again for your PR.

mkwsra commented 6 months ago

Salams,

Thanks for your message, and sounds good I will see what I can do, and all thanks are to you for doing this plugin.