Closed 125m125 closed 4 years ago
I guess that @mokkabonna considered inquirer
depends rxjs
so that rxjs
is not in dependencies.
@mokkabonna If so, it seems to be mistake because rxjs is appearing in inquirer's node_modules, so inquirer-autocomplete-prompt can't reach it, unless it listed directly in dependencies or in dependencies of upper projects. So if you using some package directly, you should list it in your dependencies. So it is good idea to merge this pr. Or am I mistaken?
Fixed in #113
Moving inquirer to dev- and peerDependencies caused rxjs to become a dev-dependency ( https://github.com/mokkabonna/inquirer-autocomplete-prompt/commit/ae9ff83e9a1a7eae38e3d89b0c353001afdc10a8#diff-32607347f8126e6534ebc7ebaec4853dR1880 ). In some cases, this leads to errors because rxjs is not installed at a place that can be reached from inquirer-autocomplete-prompt. This happened for example at https://github.com/125m125/splconfigurator/pull/145, where rxjs is installed in the node_modules folder of inquirer:
Which caused this error message ( https://travis-ci.org/125m125/splconfigurator/jobs/426576292#L446 ):
Adding rxjs as production dependency solves this problem.