mokus80 / learners_directory

4 stars 4 forks source link

GitHub keys should be removed from the public repository #10

Closed DanielKehoe closed 11 years ago

DanielKehoe commented 11 years ago

The file config/initializers/omniauth.rb contains your GitHub access keys and is available in the public repo. That means someone can use your keys for their own purposes.

You can use environment variables instead. See my article: http://railsapps.github.io/rails-environment-variables.html or the "Configure" chapter of the "Learning Rails" book or an example application: https://github.com/RailsApps/rails3-mongoid-omniauth

PragTob commented 11 years ago

:+1:

netroy commented 11 years ago

keys still exist in https://github.com/mokus80/learners_directory/blob/master/.env

mokus80 commented 11 years ago

These are the old keys, I generated new ones. However, you are right, I should remove this file.