search

mokus80 / learners_directory

4 stars 4 forks source link

Enable therubyracer gem #14

Open ohookins opened 10 years ago

ohookins commented 10 years ago

What do you think of uncommenting the line that installs therubyracer? On my Vagrant test machine at least I couldn't progress with running the app before installing this gem.

ohookins commented 10 years ago

@PragTob

PragTob commented 10 years ago

I'm not quite sure, I think we should be good with execjs if I remember correctly it checks whether you got a runtime env installed (like node) and if not install therubyracer or something.

Dunno why/when the thrubyracer was commented out.

ohookins commented 10 years ago

For me it failed hard, suggesting I check out the URL in the Gemfile but didn't install any JS runtime.

PragTob commented 10 years ago

Okay so I believe therubyracer can't be in there due to heroku. So we could put it under development. A quick survey (well between me and a friend) showed that mostly you should probably use node e.g. sudo apt-get install node.

I don't know what execjs will do if it finds both. It'll probably choose node. So yeah we should have installing node in the README or therubyracer in development (and maybe test) environments. Probably both. Not too familiar if anything has changed in 4.0 about that.