search

mokus80 / learners_directory

4 stars 4 forks source link

Add links to coaches' GitHub accounts #15

Closed osg closed 10 years ago

osg commented 10 years ago

This is an easy issue for you to practice the workflow of fixing issues in GitHub. :)

In the README.rdoc file, add links to the coaches' GitHub accounts. This makes it convenient for the reader to learn more about the coaches.

osg commented 10 years ago

Suggestion: Include rationale for closing an issue, especially if there is no fix. Doing so is also useful if you yourself want to go back to the history of an issue and remember what you decided at a given moment in time.

andoneve commented 10 years ago

thanks :)

On Wed, Oct 16, 2013 at 3:44 PM, Ursula Kallio notifications@github.comwrote:

Suggestion: Include rationale for closing an issue, especially if there is no fix. Doing so is also useful if you yourself might want to go back to the history of an issue and remember what you decided at a given moment in time.

— Reply to this email directly or view it on GitHubhttps://github.com/mokus80/learners_directory/issues/15#issuecomment-26418430 .

laura pierson wadden +49 0176 8773 3595

andoneve commented 10 years ago

I thought the changes were saved but never got committed.

osg commented 10 years ago

If you want, you can add a verify step where someone else closes the issue after they have verified that they see the fix. (Usually helpful for larger projects.)

PragTob commented 10 years ago

They probably were committed not pushed.

You can reference issues from commit messages like so:

fixes #ISSUE_NUMBER (or just #ISSUE_NUMBER)

with the fixes thing, the issues are automatically closed as soon as the commits are merged into master and a reference to the commit appears in the issue. With the latter one, just a reference appears.

andoneve commented 10 years ago

pragtob, thanks for the tip! did it :)

PragTob commented 10 years ago

Awesome sauce!!! :+1: