molbal / abyss-tracker

EVE Online Abyss loot tracker webapplication
https://abyss.eve-nt.uk
GNU Affero General Public License v3.0
22 stars 3 forks source link

Total estimated value doesn't include "before cargo" list in calculation (new run creation page) #98

Open vilnytskyi opened 3 years ago

vilnytskyi commented 3 years ago

Describe the bug When I use "My cargo is not empty!" option then total loot value doesn't exclude items specified in "Before cargo" input

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Add run'
  2. Click on 'My cargo is not empty!'
  3. Paste some loot in both textareas
  4. Check "Total value is approximately"

Expected behavior "Before cargo" list's total value should be excluded from "After cargo" list's value.

Additional context Honestly, I was planning to fix it by myself, but it's easier to farm my next Omega in abyss than to figure out how to set up a working dev environment with all that stuff project is currently built with... Gave up after fixing several "composer update" errors due to package versions incompatibility (not a php dev myself though).

molbal commented 3 years ago

Hey,

It's been a long bug thats relatively easy to fix - I agree, that a dev environment is painful to set up. I shall make a guide for contributors and make a DB that you can import without opsec data in it.

Plus the project uses Laravel nova to make my life easier, but I purchased a license for it, which does not let me share that package. (That's why I put that in a separate private repo)

Long story short, I'm working on an opsec patch now and I'll fix this bug after that's online. (After 2021.06.07)