search

molecular-playground / ms-users

A microservice for business logic regarding user data.
0 stars 0 forks source link

Error reporting on bad login cridentials #9

Closed GaryPWhite closed 8 years ago

GaryPWhite commented 8 years ago

I'm noticing that when there is an invalid user/email I'm returned 200 with a message inside. an error status code would be more useful for the use cases of returning this information. 417 Expectation Failed or 400 Bad Request with a verbose message I think would do perfectly. Thanks guys!

GaryPWhite commented 8 years ago

login credentials ^^ logging in

GaryPWhite commented 8 years ago

but just in general, getting an error for a bad request, improper parameters, anything like that, would be easier to handle on my end because we can use a different callback for it instead of handling it all in the same function. Plus it prints to the console automatically.

alechirsch commented 8 years ago

Yeah, I thought we fixed all of those issues. We seem to have missed some.

GaryPWhite commented 8 years ago

:+1:

alechirsch commented 8 years ago

All of the error handling is fixed and will be pushed to the server later tonight (hopefully).

stanleyrya commented 8 years ago

Pushed! Let's hope it works :laughing: