moleculemaker / chemscraper-frontend

MIT License
1 stars 0 forks source link

Design Audit Feedback (April 2024) #101

Open KastanDay opened 4 months ago

KastanDay commented 4 months ago

I'm addressing the round of feedback here: https://www.figma.com/file/P9nzk24NcOppCZ3GcggQ3B/ChemScraper?type=design&node-id=3108-417&mode=design&t=maCpycthbMv4eYSs-0

KastanDay commented 3 months ago

I added error handling for failed analysis jobs. At least now we see the 404, or whatever error text, instead of staring at an infinite spinner.

CleanShot 2024-05-20 at 12 55 45

KastanDay commented 1 month ago

Final nits:

KastanDay commented 1 month ago

@matthewberry and @bodom0015 this PR is ready for review and merge.

It's deployed to staging.

I've tested it thoroughly and strongly believe it's all working great.

It addresses 99% of the design audit feedback, all the major notes. It's just missing tiny details in spacing, layout & beauty.

Final nits: