moleculemaker / chemscraper-frontend

MIT License
1 stars 0 forks source link

fix: workaround for error in getByJobTypeAndJobIdAndRunId #102

Closed bodom0015 closed 3 months ago

bodom0015 commented 3 months ago

Problem

Frontend has trouble fetching job results after adding Kubernetes job support

Approach

How to Test

Test this with https://github.com/moleculemaker/mmli-backend/pull/43

Currently deployed on prod: https://chemscraper.platform.moleculemaker.org

  1. Navigate to https://chemscraper.platform.moleculemaker.org/configuration
  2. Submit a real (known-good) PDF for analysis
  3. Wait for job to complete
    • You should eventually see the results load and display
KastanDay commented 3 months ago

In testing, after uploading a file the button "Analyze with Chemscraper" remains disabled, so I can't submit the job. Same with the example pdf.

The network tab shows the Upload responds with 200.

Request URL: https://mmli.fastapi.staging.mmli1.ncsa.illinois.edu/chemscraper/upload?job_id=
Request Method: POST
Status Code: 200 OK

CleanShot 2024-05-16 at 15 25 30

bodom0015 commented 3 months ago

Thank you, @KastanDay! I think you fixed this issue in the base branch, so it should be fixed here as well :+1:

Is it ok that we are merging this into design-audit-feedback-round-2? Or should I put this on main instead and have you pull into your branch?

Do you have any preference here?

KastanDay commented 3 months ago

@bodom0015 No preference! Go for main, then it's nice and independent.

KastanDay commented 3 months ago

I tested again today with both the Example PDF and a random chem PDF, still working great. Merging.