search

moleculemaker / clean-frontend

web frontend for CLEAN tool
MIT License
1 stars 0 forks source link

Mjberry/validate sequences immediately #61

Closed matthewberry closed 1 year ago

matthewberry commented 1 year ago

Leigh found in her user testing that people were pasting data into the textarea, but the validation wasn't occurring. With the previous code, the user had to de-focus the textarea (e.g., click on something else) to trigger validation. This PR changes the interaction so that validation happens without de-focusing the textarea.

UPDATE: Sorry, I created this PR while talking to Leigh and accidentally based it on your open PR's branch, Chia-Han. The diffs therefore include all of your branch's changes, too. The only new change here is on line 26 of src/app/components/clean/configuration/configuration.component.html.

EdwinKuo1337 commented 1 year ago

So I think we don't need to merge the old one created by me after we merge this PR right?

matthewberry commented 1 year ago

So I think we don't need to merge the old one created by me after we merge this PR right?

@EdwinKuo1337 That would work, but I'll let you merge your PR first, and then I'll merge this one. (I'm starting to review your recent changes now!)